[Span First #3]: Add active span parenting behaviour and more api scaffolding #3377

buenaflor · 2025-12-02T21:31:17Z

📜 Description

Span first initiative

💡 Motivation and Context

Part of #3331

💚 How did you test it?

Unit tests

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
I updated the docs if needed
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog

codecov · 2025-12-02T21:38:56Z

Codecov Report

❌ Patch coverage is 66.15385% with 22 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feat/span-first@fd7a63c). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
packages/dart/lib/src/protocol/unset_span.dart	0.00%	14 Missing ⚠️
packages/dart/lib/src/protocol/noop_span.dart	33.33%	4 Missing ⚠️
packages/dart/lib/src/hub_adapter.dart	0.00%	2 Missing ⚠️
packages/dart/lib/src/noop_hub.dart	0.00%	1 Missing ⚠️
packages/dart/lib/src/scope.dart	90.90%	1 Missing ⚠️

Additional details and impacted files

@@                Coverage Diff                 @@
##             feat/span-first    #3377   +/-   ##
==================================================
  Coverage                   ?   87.94%           
==================================================
  Files                      ?      295           
  Lines                      ?    10069           
  Branches                   ?        0           
==================================================
  Hits                       ?     8855           
  Misses                     ?     1214           
  Partials                   ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

buenaflor · 2025-12-02T21:39:55Z

cursor review

cursor

Bug: Scope clear() does not reset active spans list

The Scope.clear() method, intended to reset the scope, doesn't clear the _activeSpans list. This leaves stale spans, leading to incorrect parenting for new spans and inconsistency with other cleared collection fields.

packages/dart/lib/src/scope.dart#L297-L316

sentry-dart/packages/dart/lib/src/scope.dart

Lines 297 to 316 in 144405e

    
             /// Resets the Scope to its default state 
        
             Future<void> clear() async { 
        
               clearAttachments(); 
        
               level = null; 
        
               span = null; 
        
               _transaction = null; 
        
               _fingerprint = []; 
        
               _tags.clear(); 
        
               _extra.clear(); 
        
               _eventProcessors.clear(); 
        
               _replayId = null; 
        
               propagationContext = PropagationContext(); 
        
               _attributes.clear(); 
        
               _clearBreadcrumbsSync(); 
        
               _setUserSync(null); 
        
               await clearBreadcrumbs(); 
        
               await setUser(null); 
        
             }

packages/dart/lib/src/scope.dart#L45-L78

sentry-dart/packages/dart/lib/src/scope.dart

Lines 45 to 78 in 144405e

    
             final List<Span> _activeSpans = []; 
        
             @visibleForTesting 
        
             List<Span> get activeSpans => List.unmodifiable(_activeSpans); 
        
             /// Returns the currently active span, or `null` if no span is active. 
        
             /// 
        
             /// The active span is the most recently set span via [setActiveSpan]. 
        
             /// When starting a new span with `active: true` (the default), the new span 
        
             /// becomes a child of this active span. 
        
             @internal 
        
             Span? getActiveSpan() { 
        
               return _activeSpans.lastOrNull; 
        
             } 
        
             /// Sets the given [span] as the currently active span. 
        
             /// 
        
             /// Active spans are used to automatically parent new spans. 
        
             /// When a new span is started with `active: true` (the default), it becomes 
        
             /// a child of the currently active span. 
        
             @internal 
        
             void setActiveSpan(Span span) { 
        
               _activeSpans.add(span); 
        
             } 
        
             /// Removes the given [span] from the active spans list. 
        
             /// 
        
             /// This should be called when a span ends to remove it from the active 
        
             /// span hierarchy. 
        
             @internal 
        
             void removeActiveSpan(Span span) { 
        
               _activeSpans.remove(span); 
        
             }

packages/dart/lib/src/protocol/simple_span.dart

packages/dart/lib/src/protocol/noop_span.dart

buenaflor added 5 commits November 28, 2025 16:13

Update

63e3107

Updateg

eb0cdef

Update

19a8c19

Update

8713bfc

Update

1adb9a3

buenaflor changed the title ~~feat(spans-first): Add active span and more Span API scaffolding~~ feat(spans-first): Add active span parenting behaviour and more Span API scaffolding Dec 2, 2025

buenaflor changed the title ~~feat(spans-first): Add active span parenting behaviour and more Span API scaffolding~~ feat(spans-first): Add active span parenting behaviour and more api scaffolding Dec 2, 2025

buenaflor added 4 commits December 2, 2025 22:32

Remove unnecessary import

5e74caa

Remove unnecessary import

b1a3832

Update

c7cbeea

Update

144405e

buenaflor added 2 commits December 2, 2025 22:40

Update

ab66ec9

Update

7d685be

cursor bot reviewed Dec 2, 2025

View reviewed changes

packages/dart/lib/src/protocol/simple_span.dart Outdated Show resolved Hide resolved

packages/dart/lib/src/protocol/noop_span.dart Outdated Show resolved Hide resolved

buenaflor added 4 commits December 2, 2025 23:34

Update

33d8892

Update

d74fe5a

Update

2b9c8b2

Update

c5a24b4

buenaflor changed the title ~~feat(spans-first): Add active span parenting behaviour and more api scaffolding~~ [Span First #3]: Add active span parenting behaviour and more api scaffolding Dec 2, 2025

Update

540851d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[Span First #3]: Add active span parenting behaviour and more api scaffolding #3377

[Span First #3]: Add active span parenting behaviour and more api scaffolding #3377

Uh oh!

buenaflor commented Dec 2, 2025 •

edited

Loading

Uh oh!

codecov bot commented Dec 2, 2025 •

edited

Loading

Uh oh!

buenaflor commented Dec 2, 2025

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	/// Resets the Scope to its default state
	Future<void> clear() async {
	clearAttachments();
	level = null;
	span = null;
	_transaction = null;
	_fingerprint = [];
	_tags.clear();
	_extra.clear();
	_eventProcessors.clear();
	_replayId = null;
	propagationContext = PropagationContext();
	_attributes.clear();

	_clearBreadcrumbsSync();
	_setUserSync(null);

	await clearBreadcrumbs();
	await setUser(null);
	}


	final List<Span> _activeSpans = [];

	@visibleForTesting
	List<Span> get activeSpans => List.unmodifiable(_activeSpans);

	/// Returns the currently active span, or `null` if no span is active.
	///
	/// The active span is the most recently set span via [setActiveSpan].
	/// When starting a new span with `active: true` (the default), the new span
	/// becomes a child of this active span.
	@internal
	Span? getActiveSpan() {
	return _activeSpans.lastOrNull;
	}

	/// Sets the given [span] as the currently active span.
	///
	/// Active spans are used to automatically parent new spans.
	/// When a new span is started with `active: true` (the default), it becomes
	/// a child of the currently active span.
	@internal
	void setActiveSpan(Span span) {
	_activeSpans.add(span);
	}

	/// Removes the given [span] from the active spans list.
	///
	/// This should be called when a span ends to remove it from the active
	/// span hierarchy.
	@internal
	void removeActiveSpan(Span span) {
	_activeSpans.remove(span);
	}

Uh oh!

[Span First #3]: Add active span parenting behaviour and more api scaffolding #3377

Are you sure you want to change the base?

[Span First #3]: Add active span parenting behaviour and more api scaffolding #3377

Uh oh!

Conversation

buenaflor commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

codecov bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

buenaflor commented Dec 2, 2025

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Scope clear() does not reset active spans list

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

buenaflor commented Dec 2, 2025 •

edited

Loading

codecov bot commented Dec 2, 2025 •

edited

Loading